ccaominh commented on a change in pull request #9536: Web console: Clean up
spec before reopening in data loader
URL: https://github.com/apache/druid/pull/9536#discussion_r395330438
##########
File path: web-console/src/views/load-data-view/load-data-view.tsx
##########
@@ -2967,7 +2968,7 @@ export class LoadDataView extends
React.PureComponent<LoadDataViewProps, LoadDat
try {
const resp = await axios.get(`/druid/indexer/v1/task/${initTaskId}`);
- this.updateSpec(resp.data.payload);
+ this.updateSpec(cleanSpec(resp.data.payload));
Review comment:
Yeah, that's a good unit test for the utility method.
I was thinking it'd also be nice to have something that ensures the load
data view itself is behaving as expected (e.g., it should be calling
`cleanSpec` in the right places).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
