jihoonson commented on a change in pull request #8992: druid extension for OpenID Connect auth using pac4j lib URL: https://github.com/apache/druid/pull/8992#discussion_r396128681
########## File path: licenses.yaml ########## @@ -136,6 +136,16 @@ source_paths: --- +name: code adapted from Apache Knox KnoxSessionStore and ConfigurableEncryptor +license_category: source +module: java-core Review comment: Hmm, probably this should be `extensions/druid-pac4j`. I'm not sure why we started to specify the module name in the license file in the first place even though libraries can be used in multiple modules. Per my understanding, the idea is we prioritize the `java-core` module if the library is used in the core as well as extensions. If the library is used in only an extension, it should be the extension name. See https://github.com/apache/druid/blob/master/licenses.yaml#L2954 as an example. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
