himanshug commented on a change in pull request #8992: druid extension for OpenID Connect auth using pac4j lib URL: https://github.com/apache/druid/pull/8992#discussion_r396661663
########## File path: licenses.yaml ########## @@ -136,6 +136,16 @@ source_paths: --- +name: code adapted from Apache Knox KnoxSessionStore and ConfigurableEncryptor +license_category: source +module: java-core Review comment: I am not too familiar with `licenses.yaml` file , I only did the changes based on copy-paste and to make build pass. It would be great to document somewhere more details about this file, what it does and how it is used for verification etc. I agree that when a dep is added, it could be used anywhere, so no need to add a specific module attribute if possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
