jihoonson commented on a change in pull request #9553: fix Hadoop ingestion 
fails due to error 'JavaScript is disabled' on certain config
URL: https://github.com/apache/druid/pull/9553#discussion_r396711214
 
 

 ##########
 File path: 
indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopDruidIndexerConfig.java
 ##########
 @@ -138,6 +138,20 @@
     ROWS_THROWN_AWAY_COUNTER
   }
 
+  public static Map<String, String> getAllowedProperties(List<String> 
listOfAllowedPrefix)
 
 Review comment:
   `listOfAllowedPrefix` seems to always be the `allowedHadoopPrefix` of this 
class. Can it be a non-static method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to