jihoonson commented on a change in pull request #9530: DruidSegmentReader 
should work if timestamp is specified as a dimension
URL: https://github.com/apache/druid/pull/9530#discussion_r398077218
 
 

 ##########
 File path: 
integration-tests/src/test/java/org/apache/druid/tests/indexer/ITIndexerTest.java
 ##########
 @@ -34,16 +34,25 @@
   private static final String INDEX_QUERIES_RESOURCE = 
"/indexer/wikipedia_index_queries.json";
   private static final String INDEX_DATASOURCE = "wikipedia_index_test";
 
+  private static final String INDEX_WITH_TIMESTAMP_TASK = 
"/indexer/wikipedia_with_timestamp_index_task.json";
+  // TODO: add queries that validate timestamp is different from the __time 
column since it is a dimension
 
 Review comment:
   Would you open an issue for this instead of TODO?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to