jihoonson commented on a change in pull request #8623: Consolidate and bump the
protobuf version
URL: https://github.com/apache/druid/pull/8623#discussion_r398200501
##########
File path:
extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufInputRowParser.java
##########
@@ -127,49 +127,59 @@ void initDescriptor()
private Descriptor getDescriptor(String descriptorFilePath)
{
- InputStream fin;
-
- fin =
this.getClass().getClassLoader().getResourceAsStream(descriptorFilePath);
+ InputStream fin =
this.getClass().getClassLoader().getResourceAsStream(descriptorFilePath);
Review comment:
nit: can we use the `try-with-resources` instead of `CloseQuiently.close()`?
I guess we can do if we extract creating `fin` as a method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
