jihoonson commented on a change in pull request #9563: add lane enforcement for
joinish queries
URL: https://github.com/apache/druid/pull/9563#discussion_r398895308
##########
File path:
server/src/main/java/org/apache/druid/server/LocalQuerySegmentWalker.java
##########
@@ -107,17 +116,25 @@ public LocalQuerySegmentWalker(
// Note: Not calling 'postProcess'; it isn't official/documented
functionality so we'll only support it where
// it is already supported.
return new FluentQueryRunnerBuilder<>(queryRunnerFactory.getToolchest())
- .create(baseRunner)
+ .create(scheduler.wrapQueryRunner(baseRunner))
.applyPreMergeDecoration()
.mergeResults()
.applyPostMergeDecoration()
.emitCPUTimeMetric(emitter, cpuAccumulator);
}
-
@Override
public <T> QueryRunner<T> getQueryRunnerForSegments(final Query<T> query,
final Iterable<SegmentDescriptor> specs)
{
// SegmentWranglers only work based on intervals and cannot run with
specific segments.
throw new ISE("Cannot run with specific segments");
}
+
+ private <T> Query<T> prioritizeAndLaneQuery(Query<T> query,
Iterable<Segment> segments)
+ {
+ Set<SegmentServerSelector> segmentServerSelectors = new HashSet<>();
+ for (Segment s : segments) {
+ segmentServerSelectors.add(new SegmentServerSelector(null,
s.getId().toDescriptor()));
Review comment:
Would you add `@Nullable` to the constructor parameter of
`SegmentServerSelector` and `getServer()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
