clintropolis commented on a change in pull request #9546: support schemaless
ingestion for transformed dimensions
URL: https://github.com/apache/druid/pull/9546#discussion_r399139991
##########
File path:
processing/src/main/java/org/apache/druid/segment/transform/TransformSpec.java
##########
@@ -44,19 +44,23 @@
*/
public class TransformSpec
{
- public static final TransformSpec NONE = new TransformSpec(null, null);
+ public static final TransformSpec NONE = new TransformSpec(null, null, null);
private final DimFilter filter;
private final List<Transform> transforms;
+ private final List<String> addDimensions;
+
@JsonCreator
public TransformSpec(
@JsonProperty("filter") final DimFilter filter,
- @JsonProperty("transforms") final List<Transform> transforms
+ @JsonProperty("transforms") final List<Transform> transforms,
+ @JsonProperty("addDimensions") final List<String> addDimensions
Review comment:
This seems like it could work, without the downside of always including them
as dimensions. The alternative I guess would be adding a `isDimension` to the
`Transform` interface? I'm not sure which is better, though the way you've done
it here is definitely less intrusive in terms of modifications.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
