yuanlihan opened a new pull request #9573: Fix some flaws of KafkaEmitter
URL: https://github.com/apache/druid/pull/9573
 
 
   
   ### Description
   There are some flaws in `KafkaEmitter`:
   1. annoying error logs(see 
[KAFKA-4854](https://issues.apache.org/jira/browse/KAFKA-4854)), like this 
   `2020-03-27T09:53:02,057 ERROR [kafka-producer-network-thread | producer-1] 
org.apache.kafka.clients.producer.internals.RecordBatch - Error executing 
user-provided callback on message for topic-partition 'druid_metrics_test-0'
   java.lang.NullPointerException`
   2. the `start` method is called twice by the `LifecycleStart` framework
   3. redundant periodic scheduling of send tasks
   
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] been tested in a test Druid cluster.
   
   <hr>
   
   ##### Key changed class in this PR
    * `KafkaEmitter `
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to