jihoonson commented on a change in pull request #8272: Support incremental load
in Druid lookups
URL: https://github.com/apache/druid/pull/8272#discussion_r399416386
##########
File path:
extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/JdbcCacheGenerator.java
##########
@@ -150,6 +187,38 @@ private static String buildLookupQuery(String table,
String filter, String keyCo
);
}
+ private String buildIncrementalLookupQuery(
+ final CacheScheduler.EntryImpl<JdbcExtractionNamespace> key,
+ final JdbcExtractionNamespace namespace,
+ String tsColumn, Long lastLoadTs)
+ {
+ final DBI dbi = ensureDBI(key, namespace);
Review comment:
> [ERROR] Dead store to dbi in
org.apache.druid.server.lookup.namespace.JdbcCacheGenerator.buildIncrementalLookupQuery(CacheScheduler$EntryImpl,
JdbcExtractionNamespace, String, Long)
[org.apache.druid.server.lookup.namespace.JdbcCacheGenerator] At
JdbcCacheGenerator.java:[line 195] DLS_DEAD_LOCAL_STORE
I think the spotbugs is complaining that this variable is not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
