himanshug commented on a change in pull request #9568: fix
MAX_INTERMEDIATE_SIZE for DoubleMeanHolder
URL: https://github.com/apache/druid/pull/9568#discussion_r399473887
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/mean/DoubleMeanAggregatorFactory.java
##########
@@ -152,6 +152,8 @@ public Object deserialize(Object object)
return
DoubleMeanHolder.fromBytes(StringUtils.decodeBase64(StringUtils.toUtf8((String)
object)));
} else if (object instanceof DoubleMeanHolder) {
return object;
+ } else if (object instanceof byte[]) {
Review comment:
I meant, just move the byte[] check as being the first check in if-statement
chain as I am expecting that would be the case most of the time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
