jihoonson commented on issue #9588: Allow Cloud Deep Storage configs without segment bucket or path specified URL: https://github.com/apache/druid/pull/9588#issuecomment-606303285 As I commented on a [similar PR](https://github.com/apache/druid/pull/9296#pullrequestreview-351220321), I'm wondering whether it's better to split the inputSources and the deep storage types into different extensions. I think it's better to split them because 1) the configurations will be still non-nulls and thus you don't have to add null checks everywhere which is less error-prone. 2) the error will be still thrown during the initialization instead of when a relevant method is called while the cluster is running. This could matter because it would be nice to fail fast when some configuration is accidentally wrong so that users don't have to restart the cluster whenever they find wrong configurations. 3) if we unify all extension inputSources as a separate extension, users can just choose the new extension to use all input source types which is better than listing all different extensions in the load list.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
