suneet-s commented on issue #9590: Add integration tests for ingestion with 
transformSpec
URL: https://github.com/apache/druid/pull/9590#issuecomment-606676972
 
 
   > 
   > I am thinking of parameterizing the json files themself across the new 
json files you added
   
   I think parameterizing the json files is a great idea, but there's a lot of 
tight coupling between the json files and the base IT classes. I'm not sure 
where the best place to do this is because of that. 
   
   I'd rather do the parameterization in a separate change - when #9591 #9592  
or #9589  are fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to