suneet-s opened a new pull request #9605: Fix potential integer overflow in BufferArrayGrouper URL: https://github.com/apache/druid/pull/9605 This change fixes a potential integer overflow in BufferArrayGrouper that was flagged by LGTM. It also adds a check that the vectorized arrays are initialized before aggregateVector is called. The changes in HashTableUtils should not have any effect since the numbers being multiplied are small, but the change will remove the warnings from being flagged in LGTM. For this to happen, the number of rows needs to be >= Int.MAX/4 I can't tell by reading the code whether the VectorCursorGranularizer actually produces a situation like this in a production cluster. <hr> This PR has: - [ ] been self-reviewed. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ ] been tested in a test Druid cluster.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
