ccaominh commented on a change in pull request #9339: IntelliJ inspections 
cleanup
URL: https://github.com/apache/druid/pull/9339#discussion_r406375081
 
 

 ##########
 File path: services/src/main/java/org/apache/druid/cli/CliHadoopIndexer.java
 ##########
 @@ -84,8 +84,8 @@ public void run()
         extensionURLs.addAll(Arrays.asList(((URLClassLoader) 
extensionLoader).getURLs()));
       }
 
-      final List<URL> nonHadoopURLs = new ArrayList<>();
-      nonHadoopURLs.addAll(Arrays.asList(((URLClassLoader) 
CliHadoopIndexer.class.getClassLoader()).getURLs()));
+      final List<URL> nonHadoopURLs = new 
ArrayList<>(Arrays.asList(((URLClassLoader) 
CliHadoopIndexer.class.getClassLoader())
 
 Review comment:
   The `new ArrrayList<>()` seems unnecessary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to