suneet-s commented on a change in pull request #9648: SQL: More straightforward
handling of join planning.
URL: https://github.com/apache/druid/pull/9648#discussion_r406487575
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidJoinQueryRel.java
##########
@@ -395,4 +365,14 @@ private static boolean computeRightRequiresSubquery(final
DruidRel<?> right)
return Pair.of(rightPrefix, signatureBuilder.build());
}
+
+ private static DruidRel<?> getSomeDruidChild(final RelNode child)
+ {
+ if (child instanceof DruidRel) {
+ return (DruidRel<?>) child;
+ } else {
+ final RelSubset subset = (RelSubset) child;
Review comment:
when I wrote this, I was wondering whether bindable parameters would change
the node here somehow. The calcite query tests are pretty comprehensive around
different types of JOINs and nested queries, that I feel pretty confident to
agree with your understanding. Any chance you can test this with parameterized
sql.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
