JulianJaffePinterest opened a new pull request #9693: Allow bootstrap.servers to be provided for Kafka ingestion. URL: https://github.com/apache/druid/pull/9693 Addresses #8685, allowing for `bootstrap.servers` to be provided by a PasswordProvider instead of hard-coded. ### Description <!-- Describe your patch: what did you change in code? How did you fix the problem? --> Modified `KafkaRecordSupplier.addConsumerPropertiesFromConfig` to check for a password provider when deserializing `bootstrap.servers` as it currently does when deserializing trust and key store passwords. This does not implement the further suggestion on #8685 to allow any field to be provided by a PasswordProvider because #6666 is still an open issue. <hr> This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. <hr> ##### Key changed/added classes in this PR * `KafkaRecordSupplier`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
