himanshug commented on issue #9701: DruidLeaderClient always thinks the first node returned from DruidNodeDiscovery is the leader URL: https://github.com/apache/druid/issues/9701#issuecomment-613782915 ah, I see , wasn't aware of this change. I agree, right fix is to make it follow leader. for now, I think right way to fix it to not revert #9481 but rather use `DruidLeaderSelector` interface to get the leader.. so as to not add hardcoded dependency back to zk. Similar to what router is doing `DruidLeaderSelector.getCurrentLeader()` for example https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/server/AsyncManagementForwardingServlet.java#L95 that will revert the behavior equivalent to using zk specific `ServerDiscoverySelector` let me do a PR unless someone sees problems with that .. @gianm @jihoonson ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
