gianm commented on a change in pull request #9704: Refresh query docs.
URL: https://github.com/apache/druid/pull/9704#discussion_r409066357
 
 

 ##########
 File path: docs/misc/math-expr.md
 ##########
 @@ -22,9 +22,14 @@ title: "Expressions"
   ~ under the License.
   -->
 
-
-> This feature is still experimental. It has not been optimized for 
performance yet, and its implementation is known to
->  have significant inefficiencies.
 
 Review comment:
   IIRC, a couple things:
   
   - Improved performance by adding various optimized selectors like 
SingleStringInputDimensionSelector, 
SingleLongInputCachingExpressionColumnValueSelector, 
SingleStringInputCachingExpressionColumnValueSelector.
   - Battle tested by having expressions be the main way of handling pre- and 
post-aggregation projections in Druid SQL.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to