maytasm commented on a change in pull request #9714: More Hadoop integration tests URL: https://github.com/apache/druid/pull/9714#discussion_r409921208
########## File path: integration-tests/src/test/java/org/apache/druid/tests/hadoop/ITHadoopIndexTest.java ########## @@ -19,87 +19,147 @@ package org.apache.druid.tests.hadoop; -import com.google.inject.Inject; +import com.google.common.collect.ImmutableList; +import org.apache.druid.indexer.partitions.DimensionBasedPartitionsSpec; +import org.apache.druid.indexer.partitions.HashedPartitionsSpec; +import org.apache.druid.indexer.partitions.SingleDimensionPartitionsSpec; import org.apache.druid.java.util.common.StringUtils; import org.apache.druid.java.util.common.logger.Logger; -import org.apache.druid.testing.IntegrationTestingConfig; import org.apache.druid.testing.guice.DruidTestModuleFactory; -import org.apache.druid.testing.utils.ITRetryUtil; import org.apache.druid.tests.TestNGGroup; -import org.apache.druid.tests.indexer.AbstractIndexerTest; -import org.testng.annotations.AfterClass; -import org.testng.annotations.BeforeClass; +import org.apache.druid.tests.indexer.AbstractITBatchIndexTest; +import org.testng.annotations.DataProvider; import org.testng.annotations.Guice; import org.testng.annotations.Test; +import java.io.Closeable; +import java.util.UUID; +import java.util.function.Function; + +/** + * IMPORTANT: + * To run this test, you must: + * 1) Copy wikipedia_index_data1.json, wikipedia_index_data2.json, and wikipedia_index_data3.json + * located in integration-tests/src/test/resources/data/batch_index/json to your HDFS at the location set in step 1. + * If using the Docker-based Hadoop container, this is automatically done by the integration tests. + * 2) Provide -Doverride.config.path=<PATH_TO_FILE> with HDFS configs set. See + * integration-tests/docker/environment-configs/override-examples/hdfs for env vars to provide. + * 3) Run the test with -Dstart.hadoop.docker=true -Dextra.datasource.name.suffix='' in the mvn command + */ @Test(groups = TestNGGroup.HADOOP_INDEX) @Guice(moduleFactory = DruidTestModuleFactory.class) -public class ITHadoopIndexTest extends AbstractIndexerTest +public class ITHadoopIndexTest extends AbstractITBatchIndexTest Review comment: Maybe we should combine TestNGGroup.HADOOP_INDEX with TestNGGroup.HDFS_DEEP_STORAGE ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
