maytasm commented on a change in pull request #9724: URL: https://github.com/apache/druid/pull/9724#discussion_r412713034
########## File path: integration-tests/src/main/java/org/apache/druid/testing/utils/StreamAdminClient.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.utils; + +import java.util.Map; + +public interface StreamAdminClient +{ + void createStream(String streamName, int partitionCount, Map<String, String> tags) throws Exception; + + void deleteStream(String streamName) throws Exception; + + void updateShardCount(String streamName, int newPartitionCount, boolean blocksUntilStarted) throws Exception; Review comment: I am really sad Kinesis and Kafka don't just call everything the same. Which then extends to our Kafka and Kinesis supervisor spec like useEarliestSequenceNumber vs useEarliestOffset. I spent an hour setting the wrong one and wondering why it wasn't working. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
