maytasm opened a new pull request #9759: URL: https://github.com/apache/druid/pull/9759
Improve "waiting for tasks complete" logic in integration tests ### Description Currently, the "waiting for tasks complete" logic in integration tests waits for all tasks regardless of the datasource of those tasks. This should never be use in integration test since integration test should be self contained, know which datasources it is testing/managing and only wait for particular datasource/s tasks to complete. The previous logic of waiting for all tasks regardless of the datasource have two problem: 1) If integration tests are run in parallel (https://github.com/apache/druid/blob/master/integration-tests/README.md#running-test-methods-in-parallel), then the old logic can be waiting (and failing from) tasks of unrelated integration tests. 2) if other random integration tests fail to clean up properly (such as leaving a long running task or a supervisor running), then other integration test using the old logic can fail mysteriously (from task that has no relation with current test method or test class at all) This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
