suneet-s commented on a change in pull request #9773:
URL: https://github.com/apache/druid/pull/9773#discussion_r416778349
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidJoinQueryRel.java
##########
@@ -328,17 +327,27 @@ private static JoinType toDruidJoinType(JoinRelType
calciteJoinType)
}
}
- private static boolean computeLeftRequiresSubquery(final DruidRel<?> left)
+ private static boolean computeLeftRequiresSubquery(final List<DruidRel<?>>
leftList)
Review comment:
What do you think about keeping this interface the same and instead
changing the private members left and right to `DruidRel<?>`
Whenever left and right is set - we can do something like `this.left =
getCheapestDruidRel(RelNode);`
As it's written, I wonder if it's possible for us to estimate that a
subquery is not required in the computeSelfCost function, but the DruidRel used
to build the native query actually uses a subquery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
