jihoonson commented on a change in pull request #9105:
URL: https://github.com/apache/druid/pull/9105#discussion_r418658092
##########
File path: docs/operations/metrics.md
##########
@@ -206,6 +206,7 @@ These metrics are for the Druid Coordinator and are reset
each time the Coordina
|`segment/dropQueue/count`|Number of segments to drop.|server.|Varies.|
|`segment/size`|Size in bytes of available segments.|dataSource.|Varies.|
|`segment/count`|Number of available segments.|dataSource.|< max|
+|`segment/totalCount`|Total number of available segments on each historical
node.||< max|
Review comment:
Is this a metric for historicals? Then it seems in a wrong section.
These are the metrics for the coordinator.
##########
File path:
server/src/main/java/org/apache/druid/server/metrics/HistoricalMetricsMonitor.java
##########
@@ -104,6 +106,8 @@ public boolean doMonitor(ServiceEmitter emitter)
emitter.emit(builder.build("segment/count", count));
}
+ emitter.emit(new ServiceMetricEvent.Builder().build("segment/totalCount",
totalCount));
Review comment:
I'm wondering whether the metrics visualization tool can compute this on
its side. Is it hard to compute for some reason?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
