wjhypo opened a new pull request #9811:
URL: https://github.com/apache/druid/pull/9811
Currently the documentation for `metricCompression` in `IndexSpec` is a bit
confusing to both the users and developers. The wording sounds like byte level
compression we pick in this config can be applied to metric columns of all
types including non primitive types like complex aggregators while in reality
the serde of complex aggregators is determined by the implementations
themselves. The confusion also amplifies when developers are adding custom
aggregators when they think they can get free byte level compression on top of
the serialized bytes they produced in `ComplexMetricSerde#getSerializer`.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
