jihoonson commented on a change in pull request #9800:
URL: https://github.com/apache/druid/pull/9800#discussion_r420345225
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/InDimFilter.java
##########
@@ -73,9 +77,14 @@
private final Supplier<DruidFloatPredicate> floatPredicateSupplier;
private final Supplier<DruidDoublePredicate> doublePredicateSupplier;
+ @JsonIgnore
+ private byte[] cacheKey;
+
@JsonCreator
public InDimFilter(
@JsonProperty("dimension") String dimension,
+ // This 'values' collection instance can be reused if possible to avoid
copying a big collection.
+ // Callers should _not_ modify the collection after it is passed to this
constructor.
@JsonProperty("values") Collection<String> values,
Review comment:
To be honest, I was lazy and haven't checked how many callers call this
constructor before. It seems small enough, I guess I can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
