a2l007 commented on a change in pull request #9449:
URL: https://github.com/apache/druid/pull/9449#discussion_r420361454
##########
File path: server/src/main/java/org/apache/druid/guice/FirehoseModule.java
##########
@@ -58,7 +59,8 @@ public void configure(Binder binder)
new NamedType(CombiningFirehoseFactory.class, "combining"),
new NamedType(FixedCountFirehoseFactory.class, "fixedCount"),
new NamedType(SqlFirehoseFactory.class, "sql"),
- new NamedType(InlineFirehoseFactory.class, "inline")
+ new NamedType(InlineFirehoseFactory.class, "inline"),
+ new NamedType(SqlInputSource.class, "sql")
Review comment:
I can refactor the module name, but I believe this module wouldn't be
needed in the broker, historical and router processes since its specific to
indexing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
