jihoonson commented on a change in pull request #9800:
URL: https://github.com/apache/druid/pull/9800#discussion_r421069133
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/NotDimFilter.java
##########
@@ -60,10 +60,17 @@ public DimFilter getField()
return ByteBuffer.allocate(1 +
subKey.length).put(DimFilterUtils.NOT_CACHE_ID).put(subKey).array();
}
+ @SuppressWarnings("ObjectEquality")
Review comment:
Thanks. I think this is fine since I don't see any reason to change them
to be not singletons in the near future. Also, we should be able to notice that
this method is not valid anymore if the assumption did change because we would
remove `instance()` methods and therefore modify this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
