yuanlihan opened a new pull request #9848:
URL: https://github.com/apache/druid/pull/9848


   
   ### Description
   This PR propose a schema changing for metadata tables to replace the varchar 
primary key with an auto-increment integer primary key. 
   
   This changing seems dogmatic and old-fashioned at first. But it really 
matters if you have been complained by the internal DBA team for the heavy load 
caused by druid metadata db.
   
   As we know that the auto-increment integer primary key usually has better 
performance than UUID primary key, especially if the table contains a large 
number of rows, eg: druid_segments and druid_pendingSegments.
   
   
   This PR has:
   - [X] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [X] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist above are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `SQLMetadataConnector`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to