clintropolis commented on a change in pull request #9857:
URL: https://github.com/apache/druid/pull/9857#discussion_r424754501



##########
File path: docs/operations/password-provider.md
##########
@@ -50,5 +50,5 @@ Please have a look at "Adding a new Password Provider 
implementation" on this [p
 To use this implementation, simply set the relevant password runtime property 
to something similar as was done for Environment variable password provider 
like -
 
 ```json
-{ "type": "<registered_password_provider_name>", "<jackson_property>": 
"<value>", ... }
+druid.metadata.storage.connector.password={ "type": 
"<registered_password_provider_name>", "<jackson_property>": "<value>", ... }

Review comment:
       should we remove the `json` typing for the code block since it isn't 
really json? It doesn't really seem to negatively impact the page rendering or 
anything though, so it's probably fine as is.
   
   <img width="827" alt="Screen Shot 2020-05-13 at 3 00 40 PM" 
src="https://user-images.githubusercontent.com/1577461/81870406-a0f81780-952a-11ea-9a5e-36b9e88fcd52.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to