clintropolis commented on a change in pull request #9858:
URL: https://github.com/apache/druid/pull/9858#discussion_r424829260
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3InputDataConfig.java
##########
@@ -29,16 +32,33 @@
*/
public class S3InputDataConfig
{
+ @VisibleForTesting
+ static final int MAX_LISTING_LENGTH_MIN = 1;
+
+ /**
+ * AWS S3 only allows deleting 1000 elements at a time:
+ *
https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/model/DeleteObjectsRequest.html
Review comment:
This seems ok to me, 1k is probably enough to list even if it isn't the
true maximum limit the API can handle.
##########
File path:
extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3InputDataConfigTest.java
##########
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.storage.s3;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.druid.java.util.common.IAE;
+import org.apache.druid.java.util.common.StringUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class S3InputDataConfigTest
+{
+ private static final int MAX_LISTING_LENGTH_TOO_LOW =
S3InputDataConfig.MAX_LISTING_LENGTH_MIN - 1;
+ private static final int MAX_LISTING_LENGTH_TOO_HIGH =
S3InputDataConfig.MAX_LISTING_LENGTH_MAX + 1;
+ private static final String INPUT_DATA_TEMPLATE_JSON_STR =
+ "{\n"
+ + " \"maxListingLength\": \"%1$d\"\n"
+ + "}";
+ private static final String INPUT_DATA_MAX_LISTING_LENGTH_TOO_LOW_JSON_STR =
Review comment:
super nit: since each of these variables is only used once and tied to a
specific test, maybe this would be slightly clearer what is going on here to
instead make a static function that wraps the `StringUtils.format` and just
call it inline for all of the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
