suneet-s commented on a change in pull request #9877:
URL: https://github.com/apache/druid/pull/9877#discussion_r426103116
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/parsers/TimestampParser.java
##########
@@ -126,14 +126,24 @@
return o -> {
Preconditions.checkNotNull(o, "null timestamp");
- if (o instanceof Number) {
+ if (o instanceof Number && isNumericFormat(format)) {
Review comment:
`isNumericFormat(format)` does not need to be computed for each object.
You can compute this outside the function that is applied per object (on line
125)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
