samarthjain commented on a change in pull request #9888:
URL: https://github.com/apache/druid/pull/9888#discussion_r426887822
##########
File path:
core/src/test/java/org/apache/druid/java/util/common/parsers/TimestampParserTest.java
##########
@@ -208,8 +208,10 @@ public void testFormatsForNumberBasedTimestamp()
expectedDt = DateTimes.of("2020-05-15T20:20:40.000Z");
parser = TimestampParser.createObjectTimestampParser("millis");
- Assert.assertEquals("Timestamp of format millis not parsed correctly",
+ Assert.assertEquals("Timestamp of format millis as long not parsed
correctly",
expectedDt, parser.apply(millis));
+ Assert.assertEquals("Timestamp of format millis as string not parsed
correctly",
Review comment:
@suneet-s - this test case passes fine without the fix in #9877. #9877
was meant for use cases where the ingested column storing time is a numeric
column (int, long) but it stores time in a format that isn't `auto || millis ||
posix || micro || nano || ruby`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
