jihoonson commented on a change in pull request #9892:
URL: https://github.com/apache/druid/pull/9892#discussion_r427728500
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/TaskResource.java
##########
@@ -37,6 +37,7 @@ public TaskResource(
)
{
this.availabilityGroup = Preconditions.checkNotNull(availabilityGroup,
"availabilityGroup");
+ Preconditions.checkArgument(requiredCapacity > 0);
Review comment:
AFAIT, we use those validation constraints for static configurations
such as `RemoteTaskRunnerConfig`. `JsonConfigProvider` binds user
configurations to some classes, and `JsonConfigurator` injects and validates
their values. `TaskResource` is not a static configuration and we don't have
such a validation framework for it as for static configurations. But I think it
would be nice to have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
