xiangqiao123 commented on pull request #9935: URL: https://github.com/apache/druid/pull/9935#issuecomment-635110688
> @xiangqiao123 thank you! Yeah, I think it would be better to address the giant lock issue in a separate PR. BTW, would you please check the CI failure? It seems legit. > > ``` > [ERROR] org.apache.druid.indexing.common.task.AppenderatorDriverRealtimeIndexTaskTest.testRestoreAfterHandoffAttemptDuringShutdown(org.apache.druid.indexing.common.task.AppenderatorDriverRealtimeIndexTaskTest) > [ERROR] Run 1: AppenderatorDriverRealtimeIndexTaskTest.testRestoreAfterHandoffAttemptDuringShutdown:1149->awaitHandoffs:1460 » TestTimedOut > [ERROR] Run 2: AppenderatorDriverRealtimeIndexTaskTest.testRestoreAfterHandoffAttemptDuringShutdown:1149->awaitHandoffs:1460 » TestTimedOut > [ERROR] Run 3: AppenderatorDriverRealtimeIndexTaskTest.testRestoreAfterHandoffAttemptDuringShutdown:1149->awaitHandoffs:1460 » TestTimedOut > [ERROR] Run 4: AppenderatorDriverRealtimeIndexTaskTest.testRestoreAfterHandoffAttemptDuringShutdown:1149->awaitHandoffs:1460 » TestTimedOut > ``` Sorry, i have fixed CI failure and optimized segmentExistsBatch method to Avoid too many elements in the in condition. @jihoonson ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
