surekhasaharan commented on pull request #9717: URL: https://github.com/apache/druid/pull/9717#issuecomment-637206061
> @surekhasaharan thanks for checking. > yeah, I noticed that we recently added code coverage expectation to builds. changes here is mostly updating existing code and new classes `InputStreamResponse***` are don't have much logic except for calling methods , ideally we could unit test it with mocks but I am not sure how much value is there. > many PRs appear to be struggling with new requirement ... maybe the newly introduced expectation around code coverage needs to be tuned down a bit. Yeah, there are discussions going on related to code coverage checks requirement, i'll wait on the decision on that, otherwise PR is good to go. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
