ccaominh opened a new pull request #9969:
URL: https://github.com/apache/druid/pull/9969


   ### Description
   
   Since there is not currently a good way to have fine-grain code coverage 
check exclusions, lower the coverage thresholds to make the check more lenient 
for now.
   
   Also, display the code coverage report in the Travis CI logs to make it 
easier to understand how to improve coverage:
   
   ```
   Diff coverage results:
   
     F = Function coverage
     L = Line coverage
     B = Branch coverage
   
   
------------------------------------------------------------------------------
   org/apache/druid/cli/validate/DruidJsonValidator.java
   
------------------------------------------------------------------------------
   254                       }
   255                   );
   256                 }
   257               
   258                 @Override
   259                 public String toString()
   260                 {
   261 F | L             return "DruidJsonValidator{" +
   262                          "logWriter=" + logWriter +
   263                          ", jsonFile='" + jsonFile + '\'' +
   264                          ", type='" + type + '\'' +
   265                          ", resource='" + resource + '\'' +
   266                          ", toLogger=" + toLogger +
   267                          '}';
   268                 }
   
------------------------------------------------------------------------------
   
   Diff coverage statistics:
   
------------------------------------------------------------------------------
   |     lines      |    branches    |   functions    |   path
   
------------------------------------------------------------------------------
   |   0% (0/1)     | 100% (0/0)     |   0% (0/1)     | 
org/apache/druid/cli/validate/DruidJsonValidator.java
   
------------------------------------------------------------------------------
   Total diff coverage:
    - lines: 0% (0/1)
    - branches: 100% (0/0)
    - functions: 0% (0/1)
   
   ERROR: Insufficient line coverage of 0% (0/1). Required 50%.
   ```
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to