samarthjain commented on a change in pull request #9603:
URL: https://github.com/apache/druid/pull/9603#discussion_r434839414
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorRuntimeParams.java
##########
@@ -56,11 +64,50 @@
return segmentsSet;
}
+ /**
+ * Creates a {@link Set} by choosing used segments from each datasource in a
round robin fashion.
+ * The order of segments picked for a datasource is dependent on the
iteration order of
+ * {@link ImmutableDruidDataSource#getSegments()}. So if it is desired to
have newer segments
+ * be picked up before the older ones, the {@link Collection} returned by
{@link ImmutableDruidDataSource#getSegments()}
+ * needs to be setup accordingly.
+ */
+ private static Set<DataSegment>
createUsedSegmentSetInRoundRobinFashion(Map<String, ImmutableDruidDataSource>
dataSourcesWithAllUsedSegments)
Review comment:
Good idea, @gianm . Will refactor and push a new commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
