jihoonson commented on a change in pull request #9971:
URL: https://github.com/apache/druid/pull/9971#discussion_r437082126
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java
##########
@@ -327,6 +327,13 @@ public TaskStatus call()
command.add(nodeType);
}
+ // If the task type is queryable, we need to load
broadcast segments on the peon, used for
+ // join queries
+ if (task.supportsQueries()) {
+ command.add("--loadBroadcastSegments");
Review comment:
Ah, the segment cache is a good point. It makes sense.
> For the coverage, I'm thinking we should ignore the coverage failure on
ForkingTaskRunner and CliPeon for this PR, does that sound okay to you?
I think it's fine.
##########
File path:
server/src/test/java/org/apache/druid/server/coordination/ZkCoordinatorTest.java
##########
@@ -67,9 +76,32 @@ public String getBase()
};
private ZkCoordinator zkCoordinator;
+ private File infoDir;
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
