suneet-s commented on a change in pull request #9997:
URL: https://github.com/apache/druid/pull/9997#discussion_r437450859
##########
File path: core/pom.xml
##########
@@ -394,6 +394,8 @@
<argLine>
@{jacocoArgLine}
-Djava.library.path=${project.build.directory}/hyperic-sigar-${sigar.base.version}/sigar-bin/lib/
+ -Duser.language=en
+ -Duser.country=US
Review comment:
@viongpanzi I tested this locally by setting different country /
languages. It appears that we only need the language set to en to get the
TimestampParserTest to parse. I don't think you need to set the country - can
you confirm?
Also, I think the issue here isn't tied to whether or not the timezone is in
UTC or not. It's an issue with the timestamp format used in the tests not being
supported by all locales.
##########
File path: core/pom.xml
##########
@@ -394,6 +394,8 @@
<argLine>
@{jacocoArgLine}
-Djava.library.path=${project.build.directory}/hyperic-sigar-${sigar.base.version}/sigar-bin/lib/
+ -Duser.language=en
+ -Duser.country=US
Review comment:
@viongpanzi I tested this locally by setting different country /
languages. It appears that we only need the language set to en to get the
TimestampParserTest to parse. I don't think you need to set the country - can
you confirm?
Also, I think the issue here isn't tied to whether or not the timezone is in
UTC or not. It's an issue with the timestamp format used in the tests not being
supported by all locales. Can you update the title of this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
