maytasm commented on a change in pull request #9965:
URL: https://github.com/apache/druid/pull/9965#discussion_r437818847



##########
File path: 
server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManager.java
##########
@@ -113,6 +114,18 @@ int markAsUsedNonOvershadowedSegments(String dataSource, 
Set<String> segmentIds)
    */
   Iterable<DataSegment> iterateAllUsedSegments();
 
+  /**
+   * Returns an iterable to go over all used and non-overshadowed segments of 
given data sources over given interval.
+   * The order in which segments are iterated is unspecified.
+   * If {@param requiresLatest} is true then a force metadatastore poll will 
be triggered. This can cause a longer
+   * response time but will ensure that the latest segment information (at the 
time this method is called) is returned.
+   * If {@param requiresLatest} is false then segment information from stale 
snapshot of up to the last periodic poll
+   * period {@link SqlSegmentsMetadataManager#periodicPollDelay} will be used.
+   */
+  Optional<Iterable<DataSegment>> 
iterateAllUsedNonOvershadowedSegmentsForDatasourceInterval(String datasource,

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to