jon-wei opened a new pull request #10015: URL: https://github.com/apache/druid/pull/10015
Fixes https://github.com/apache/druid/issues/9792 This PR fixes the above issue by having `Joinables.createSegmentMapFn` walk the query being analyzed to find instances of queries that read a `JoinDatasource`, performing the pre-analysis for these queries and storing them in a newly introduced`JoinFilterPreAnalysisGroup`. If there is only one query level that requires the join filter rewrite pre-analysis, then the group operates in a more efficient single filter mode, as hashing/comparing filters can be expensive if they're large. The parameters that control join filter rewrites have been moved into a `JoinFilterRewriteConfig` class. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
