jon-wei commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-642357853
> CI reports insufficient unit test line/function/branch coverage. Is it mandatory to meet that requirement ? Given the nature of the extension, I feel like adding an integration test that connects to Aliyun would be more useful than full unit test coverage, and I would consider that enough in terms of test coverage. We have some existing tests for S3/GCS/Azure at that you could use as a reference: ITS3ToS3ParallelIndexTest ITAzureToAzureParallelIndexTest ITGcsToGcsParallelIndexTest I'll keep you posted with more comments as I review, thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
