stefanbirkner opened a new pull request #10023:
URL: https://github.com/apache/druid/pull/10023
### Description
Avoid unnecessary coupling of test classes. Having independent classes
makes it easier to understand and modify them.
The two classes that extended CompressionStrategyTest didn't have a lot
in common with it. All of them are parameterized tests where the
parameter is a CompressionStrategy. Therefore they used the parent class
to store the value of the strategy. CompressedColumnarIntsSupplierTest
also used the @Parameters method of its parent. That's pretty much
everything that these classes had in common.
<hr>
This PR has:
- [x] been self-reviewed.
<hr>
##### Key changed/added classes in this PR
* `CompressionStrategyTest`
* `CompressedColumnarIntsSupplierTest`
* `CompressedVSizeColumnarIntsSupplierTest`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
