suneet-s commented on a change in pull request #10014:
URL: https://github.com/apache/druid/pull/10014#discussion_r441156987
##########
File path: docs/querying/sql.md
##########
@@ -287,7 +287,7 @@ to FLOAT. At runtime, Druid will widen 32-bit floats to
64-bit for most expressi
|`SQRT(expr)`|Square root.|
|`TRUNCATE(expr[, digits])`|Truncate expr to a specific number of decimal
digits. If digits is negative, then this truncates that many places to the left
of the decimal point. Digits defaults to zero if not specified.|
|`TRUNC(expr[, digits])`|Synonym for `TRUNCATE`.|
-|`ROUND(expr[, digits])`|`ROUND(x, y)` would return the value of the x rounded
to the y decimal places. While x can be an integer or floating-point number, y
must be an integer. The type of the return value is specified by that of x. y
defaults to 0 if omitted. When y is negative, x is rounded on the left side of
the y decimal points.|
+|`ROUND(expr[, digits])`|`ROUND(x, y)` would return the value of the x rounded
to the y decimal places. While x can be an integer or floating-point number, y
must be an integer. The type of the return value is specified by that of x. y
defaults to 0 if omitted. When y is negative, x is rounded on the left side of
the y decimal points. If `expr` evaluates to either `NaN`, this will return 0. |
Review comment:
```suggestion
|`ROUND(expr[, digits])`|`ROUND(x, y)` would return the value of the x
rounded to the y decimal places. While x can be an integer or floating-point
number, y must be an integer. The type of the return value is specified by that
of x. y defaults to 0 if omitted. When y is negative, x is rounded on the left
side of the y decimal points. If `expr` evaluates to either `NaN`, `expr` will
be converted to 0. If `expr` is infinity, `expr` will be converted to the
nearest finite double. |
```
##########
File path: docs/misc/math-expr.md
##########
@@ -141,7 +141,7 @@ See javadoc of java.lang.Math for detailed explanation for
each function.
|pow|pow(x, y) would return the value of the x raised to the power of y|
|remainder|remainder(x, y) would return the remainder operation on two
arguments as prescribed by the IEEE 754 standard|
|rint|rint(x) would return value that is closest in value to x and is equal to
a mathematical integer|
-|round|round(x, y) would return the value of the x rounded to the y decimal
places. While x can be an integer or floating-point number, y must be an
integer. The type of the return value is specified by that of x. y defaults to
0 if omitted. When y is negative, x is rounded on the left side of the y
decimal points.|
+|round|round(x, y) would return the value of the x rounded to the y decimal
places. While x can be an integer or floating-point number, y must be an
integer. The type of the return value is specified by that of x. y defaults to
0 if omitted. When y is negative, x is rounded on the left side of the y
decimal points. If x is `NaN`, this will return 0. |
Review comment:
```suggestion
|round|round(x, y) would return the value of the x rounded to the y decimal
places. While x can be an integer or floating-point number, y must be an
integer. The type of the return value is specified by that of x. y defaults to
0 if omitted. When y is negative, x is rounded on the left side of the y
decimal points. If x is `NaN`, x will return 0. If x is infinity, x will be
converted to the nearest finite double. |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
