clintropolis commented on pull request #10020: URL: https://github.com/apache/druid/pull/10020#issuecomment-645030570
> are there any `instanceof TableDataSource` in the code that would be incorrect now? These should all still be correct, that was part of my incentive to make `GlobalTableDataSource` be a subclass, however we probably should replace it with a property on `DataSource` which indicates that `DataSource` is backed by distributed segments, since one of the primary users of this pattern seems to be to for determining if the broker should cluster or local walker, and also join analysis stuff. However, I think I would prefer to make this change in a follow-up PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
