suneet-s commented on a change in pull request #10026:
URL: https://github.com/apache/druid/pull/10026#discussion_r441181294
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/DoubleSumAggregatorFactory.java
##########
@@ -79,8 +81,12 @@ protected VectorValueSelector
vectorSelector(VectorColumnSelectorFactory columnS
}
@Override
- public boolean canVectorize()
+ public boolean canVectorize(ColumnCapabilitiesProvider
columnCapabilitiesProvider)
{
+ if (fieldName != null) {
+ final ColumnCapabilities originalCapabilities =
columnCapabilitiesProvider.getColumnCapabilities(fieldName);
+ return expression == null && (originalCapabilities == null ||
originalCapabilities.getType().isNumeric());
Review comment:
ColumnCapabilities#type is annotated as nullable.
`originalCapabilities.getType().isNumeric()` could throw an NPE.
Same comment in Float and Long SumAggregatorFactories
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
