jihoonson commented on a change in pull request #10041:
URL: https://github.com/apache/druid/pull/10041#discussion_r441824577
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/schema/DruidSchemaTest.java
##########
@@ -222,10 +228,29 @@ public void setUp() throws Exception
serverView = new TestServerInventoryView(walker.getSegments(),
realtimeSegments);
druidServers = serverView.getDruidServers();
+ final JoinableFactory globalTableJoinable = new JoinableFactory()
+ {
+ @Override
+ public boolean isDirectlyJoinable(DataSource dataSource)
+ {
+ return dataSource instanceof GlobalTableDataSource &&
+ segmentDataSourceNames.contains(((GlobalTableDataSource)
dataSource).getName());
+ }
+
+ @Override
+ public Optional<Joinable> build(
+ DataSource dataSource, JoinConditionAnalysis condition
Review comment:
```suggestion
DataSource dataSource,
JoinConditionAnalysis condition
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
