yuanlihan commented on a change in pull request #10001:
URL: https://github.com/apache/druid/pull/10001#discussion_r441961846
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/plumber/Sink.java
##########
@@ -365,7 +372,7 @@ private FireHydrant makeNewCurrIndex(long minTimestamp,
DataSchema schema)
.setReportParseExceptions(reportParseExceptions)
.setMaxRowCount(maxRowsInMemory)
.setMaxBytesInMemory(maxBytesInMemory)
Review comment:
The `maxBytesInMemory` is calculated from max heap memory by default
while the oak incremental index will take it as available size of direct
memory. It may lead to OOM error , see
[here](https://github.com/apache/druid/issues/9967#issuecomment-645764620)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
