jihoonson commented on pull request #10025: URL: https://github.com/apache/druid/pull/10025#issuecomment-646391029
> LGTM. The huge number of impl of shardSpec makes it's a little confusing since they are not the same thing and have different purpose. Maybe the interface can be refactor so that you have the topmost parent contains a minimum with different stage of ShardSpec a child classes. And different stage of ingestion can takes in different subtype of the ShardSpec corresponding to the phase/stage. I totally agree. The approach I took in this PR was to reduce the size of the PR, but it is not the best. We can clean up them later someday. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
